Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide contracting category documents from restricted users #4136

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Hide contracting category documents from restricted users #4136

wants to merge 5 commits into from

Conversation

sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Sep 17, 2024 •
edited
Loading

Fixes #4119

image

Test Steps

  • Add restricted users' groups in Contractcategory section in admin.
  • Check if those users have access to view the document.

@frjo
Copy link
Contributor

frjo commented Sep 17, 2024

Adding all the roles with checkboxes is great for flexibility. But seeing it I start to think it would be better to reverse the logic.

"Allow document access to these groups:"

"Only selected groups will have document access."

Can we also list only Staff, Staff Admin, Finance and Contracting as options? Maybe it would be good to add this list of groups to hypha/apply/users/groups.py as "GROUPS_ORG_FACULTY" so we can reference it in other places?

By default we can then have all groups in this list checked.

@sandeepsajan0
Copy link
Member Author

image

image

image

@sandeepsajan0
Copy link
Member Author

@frjo It is ready for testing.

@frjo frjo added Status: Needs testing Tickets that need testing/qa Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team labels Sep 25, 2024
@sandeepsajan0 sandeepsajan0 force-pushed the enhancement/gh-4119-hide-contracting-forms branch from b42dbd8 to 9455f68 Compare October 18, 2024 13:57
@frjo
Copy link
Contributor

frjo commented Oct 20, 2024

Migration conflict with #3990, as soon as that one is approved we can test this one.

@frjo frjo added the Status: RTBC Internal Dev use only label Oct 24, 2024
@frjo frjo force-pushed the enhancement/gh-4119-hide-contracting-forms branch from 97a5ba4 to 125cbf0 Compare November 1, 2024 16:35
@frjo frjo added Status: Needs testing Tickets that need testing/qa Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team and removed Status: RTBC Internal Dev use only labels Nov 4, 2024
@frjo frjo force-pushed the enhancement/gh-4119-hide-contracting-forms branch from 125cbf0 to a180d98 Compare November 7, 2024 12:55
@frjo frjo force-pushed the enhancement/gh-4119-hide-contracting-forms branch from a180d98 to e0ef1e5 Compare November 7, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs dev testing 🧑‍💻 Tasks that should be tested by the dev team Status: Needs testing Tickets that need testing/qa Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide tax forms/banking info from staff, only showing finance/admins
2 participants
@sandeepsajan0 @frjo